comphead commented on code in PR #11218:
URL: https://github.com/apache/datafusion/pull/11218#discussion_r1683629448
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -565,7 +583,7 @@ impl StreamedBatch {
#[derive(Debug)]
struct BufferedBatch {
/// The buffered record batch
- pub batch: RecordBatch,
+ pub batch: Option<RecordBatch>,
Review Comment:
I think its great idea. I'll include this to follow up to simplify double
option check in favor of enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
