viirya opened a new pull request, #3835:
URL: https://github.com/apache/datafusion-comet/pull/3835
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Previously, Comet fell back to Spark for any aggregation containing a FILTER
(WHERE ...) clause (e.g. SUM(x) FILTER (WHERE y > 0)).
This patch wires the full pipeline:
Proto (expr.proto):
- Add optional Expr filter = 89 to AggExpr message
Scala serialization (QueryPlanSerde.scala):
- In aggExprToProto, serialize aggExpr.filter into the proto when
aggExpr.mode == Partial (filters are only meaningful in partial mode)
- If the filter expression cannot be serialized, fall back gracefully
Native planner (planner.rs):
- Build per-aggregate filter PhysicalExpr from agg_expr.filter
- Pass to AggregateExec::try_new instead of vec![None; num_agg]
Comet planner (operators.scala):
- Remove the blanket fallback guard for aggregate expressions with filter
SumInt and SumDecimal group accumulators:
- implement opt_filter support
- Unit tests added for each affected accumulator covering
Tests (aggregate_filter.sql):
- Update queries from expect_fallback to plain query mode now that native
execution is supported; tests verify results match Spark
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
