andygrove commented on code in PR #3835:
URL: https://github.com/apache/datafusion-comet/pull/3835#discussion_r3006297162
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -1362,12 +1362,6 @@ trait CometBaseAggregate {
return None
}
- // Aggregate expressions with filter are not supported yet.
- if (aggregateExpressions.exists(_.filter.isDefined)) {
- withInfo(aggregate, "Aggregate expression with filter is not supported")
- return None
- }
Review Comment:
This removes the guard for all aggregates with FILTER, but the PR only
modifies SUM to accept the filter. What happens for other aggregates like AVG?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
