viirya commented on code in PR #3835:
URL: https://github.com/apache/datafusion-comet/pull/3835#discussion_r3005609651
##########
dev/diffs/4.0.1.diff:
##########
@@ -245,6 +245,21 @@ index aa3d02dc2fb..c4f878d9908 100644
-- Test cases with unicode_rtrim.
WITH t(c1) AS (SELECT replace(listagg(DISTINCT col1 COLLATE unicode_rtrim)
COLLATE utf8_binary, ' ', '') FROM (VALUES ('xbc '), ('xbc '), ('a'),
('xbc'))) SELECT len(c1), regexp_count(c1, 'a'), regexp_count(c1, 'xbc') FROM t;
WITH t(c1) AS (SELECT listagg(col1) WITHIN GROUP (ORDER BY col1 COLLATE
unicode_rtrim) FROM (VALUES ('abc '), ('abc\n'), ('abc'), ('x'))) SELECT
replace(replace(c1, ' ', ''), '\n', '$') FROM t;
+diff --git
a/sql/core/src/test/resources/sql-tests/inputs/postgreSQL/aggregates_part3.sql
b/sql/core/src/test/resources/sql-tests/inputs/postgreSQL/aggregates_part3.sql
+index 0000000..0000000 100644
+---
a/sql/core/src/test/resources/sql-tests/inputs/postgreSQL/aggregates_part3.sql
++++
b/sql/core/src/test/resources/sql-tests/inputs/postgreSQL/aggregates_part3.sql
+@@ -6,6 +6,10 @@
+ --
https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/aggregates.sql#L352-L605
+
+ -- Test aggregate operator with codegen on and off.
++
++-- Floating-point precision difference between DataFusion and JVM for FILTER
aggregates
++--SET spark.comet.enabled = false
Review Comment:
The float precision difference issue is:
```
[info] - postgreSQL/aggregates_part3.sql *** FAILED *** (381 milliseconds)
[info] postgreSQL/aggregates_part3.sql
[info] Expected "2828.9682539682[954]", but got "2828.9682539682[517]"
Result did not match for query #2
[info] select sum(1/ten) filter (where ten > 0) from tenk1
(SQLQueryTestSuite.scala:683)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
