kazuyukitanimura opened a new pull request, #3849:
URL: https://github.com/apache/datafusion-comet/pull/3849
## Which issue does this PR close?
Related: #1897
## Rationale for this change
#1897 claims `tan` is incompatible; however, what is really incompatible is
`atan2` that is failing in the same test in #1896
The correct results are
```
atan2(-0.0, -0.0) = -π <= Comet answer
atan2(-0.0, +0.0) = -0.0
atan2(+0.0, -0.0) = +π
atan2(+0.0, +0.0) = +0.0 <= Spark answer
```
Looks like Spark understands `atan2(-0.0, -0.0)` as ` atan2(+0.0, +0.0)`
that is actually wrong on Spark side
## What changes are included in this PR?
Disabled `atan2` and enabled `tan`
## How are these changes tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
