andygrove commented on code in PR #3849:
URL: https://github.com/apache/datafusion-comet/pull/3849#discussion_r3028427152
##########
spark/src/main/scala/org/apache/comet/serde/math.scala:
##########
@@ -213,24 +219,6 @@ object CometAbs extends CometExpressionSerde[Abs] with
MathExprBase {
}
}
-object CometTan extends CometExpressionSerde[Tan] {
-
- override def getSupportLevel(expr: Tan): SupportLevel =
- Incompatible(
- Some(
- "tan(-0.0) produces incorrect result" +
Review Comment:
could you add a test to `tan.sql` to confirm that this now produces the same
results as Spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
