kazuyukitanimura commented on code in PR #3849:
URL: https://github.com/apache/datafusion-comet/pull/3849#discussion_r3031050891
##########
spark/src/main/scala/org/apache/comet/serde/math.scala:
##########
@@ -19,13 +19,19 @@
package org.apache.comet.serde
-import org.apache.spark.sql.catalyst.expressions.{Abs, Atan2, Attribute, Ceil,
CheckOverflow, Expression, Floor, Hex, If, LessThanOrEqual, Literal, Log,
Log10, Log2, Logarithm, Tan, Unhex}
+import org.apache.spark.sql.catalyst.expressions.{Abs, Atan2, Attribute, Ceil,
CheckOverflow, Expression, Floor, Hex, If, LessThanOrEqual, Literal, Log,
Log10, Log2, Logarithm, Unhex}
import org.apache.spark.sql.types.{DecimalType, DoubleType, NumericType}
import org.apache.comet.CometSparkSessionExtensions.withInfo
import org.apache.comet.serde.QueryPlanSerde.{exprToProtoInternal,
optExprWithInfo, scalarFunctionExprToProto,
scalarFunctionExprToProtoWithReturnType, serializeDataType}
object CometAtan2 extends CometExpressionSerde[Atan2] {
+ override def getSupportLevel(expr: Atan2): SupportLevel =
+ Incompatible(
+ Some(
+ "atan2(-0.0, -0.0) produces incompatible result" +
Review Comment:
Actually we need do more tests for atan2 to enable e.g.
```
atan2(-0.0, -0.0)
atan2(-0.0, +0.0)
atan2(+0.0, -0.0)
atan2(+0.0, +0.0)
atan2(-0.0, -1.0)
atan2(-1.0, -0.0)
atan2(-0.0, +1.0)
atan2(+1.0, -0.0)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
