edmondop commented on PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2241726131

   > > > > > I think it is because of you remove distinct from min. Do you plan 
to add `eliminate distinct in min/max` rule in another PR first? Or you can 
also deal with distinct in this PR first.
   > > > > 
   > > > > 
   > > > > I will eliminate distinct min/max in a separate PR, to avoid growing 
this too much. Where did I remove distinct from min?
   > > > 
   > > > 
   > > > I guess we could add it in analyzer rule, it is similar to 
`CountWildcardRule` in some sense.
   > > 
   > > 
   > > Can we get the test to pass without a change to analyzer rules or 
optimizers?
   > 
   > I think so, you change `distinct_min` to `min`, if you support 
`distinct_min`, it might be enough
   
   how did I change `distinct_min` to `min`? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to