jayzhan211 commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1688981789
##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -946,10 +946,22 @@ fn roundtrip_scalar_udf_extension_codec() -> Result<()> {
)),
input,
)?);
+ let udaf = AggregateUDF::from(Max::new());
+ let aggr_expr = create_aggregate_expr(
+ &udaf,
Review Comment:
@edmondop You should change to `max_udaf` here. I test it locally and the
test pass #11595 might not be an issue anymore. cc @Lordworms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
