jayzhan211 commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1685843408
##########
datafusion/optimizer/src/single_distinct_to_groupby.rs:
##########
@@ -520,17 +521,7 @@ mod tests {
let plan = LogicalPlanBuilder::from(table_scan)
.aggregate(
vec![col("a")],
- vec![
- count_distinct(col("b")),
- Expr::AggregateFunction(expr::AggregateFunction::new(
- AggregateFunction::Max,
- vec![col("b")],
- true,
Review Comment:
@edmondop You change `distinct_max` to `max` here.
##########
datafusion/optimizer/src/single_distinct_to_groupby.rs:
##########
@@ -584,18 +575,7 @@ mod tests {
let plan = LogicalPlanBuilder::from(table_scan)
.aggregate(
vec![col("a")],
- vec![
- sum(col("c")),
- count_distinct(col("b")),
- Expr::AggregateFunction(expr::AggregateFunction::new(
- AggregateFunction::Max,
- vec![col("b")],
- true,
Review Comment:
And this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
