timsaucer commented on code in PR #21573:
URL: https://github.com/apache/datafusion/pull/21573#discussion_r3069771301
##########
datafusion/physical-expr/src/intervals/cp_solver.rs:
##########
@@ -939,16 +938,8 @@ mod tests {
Interval::make(Some(100), None)?,
PropagationResult::Infeasible,
&Schema::new(vec![
- Field::new(
- left_col.as_any().downcast_ref::<Column>().unwrap().name(),
- DataType::Int32,
- true,
- ),
- Field::new(
-
right_col.as_any().downcast_ref::<Column>().unwrap().name(),
- DataType::Int32,
- true,
- ),
Review Comment:
It looks at first glance like we're removing a check on the `Column` type
but if you look higher up you can see that `left_col` is an `Arc<Column>` so
this doesn't impact the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
