timsaucer commented on code in PR #21573:
URL: https://github.com/apache/datafusion/pull/21573#discussion_r3069778762
##########
datafusion/physical-expr/src/simplifier/unwrap_cast.rs:
##########
@@ -254,9 +249,7 @@ mod tests {
let literal_expr = lit(10i64);
let binary_expr =
Arc::new(BinaryExpr::new(cast_expr, Operator::Gt, literal_expr));
- let binary_ref =
binary_expr.as_any().downcast_ref::<BinaryExpr>().unwrap();
Review Comment:
Similar to above, this test didn't really do anything other than step
through the as_any() function since binary_expr is already an `Arc<BinaryExpr>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
