adamreeve opened a new pull request, #21603:
URL: https://github.com/apache/datafusion/pull/21603

   ## Which issue does this PR close?
   
   - Closes #21602.
   
   ## Rationale for this change
   
   Fail quickly with a helpful error if we're unable to represent a 
`FileDecryptionProperties` instance as `ConfigFileDecryptionProperties`
   
   ## What changes are included in this PR?
   
   * Change the implementation of `From<&Arc<FileDecryptionProperties>>` for 
`ConfigFileDecryptionProperties` to `TryFrom`.
   * Fail the conversion if we can't get the footer key from the 
`FileDecryptionProperties` with empty metadata
   
   ## Are these changes tested?
   
   Yes I've added a new unit test.
   
   I also tested this with a branch of delta-rs that uses Datafusion with 
Parquet encryption, and this required only minor changes to tests and examples: 
https://github.com/corwinjoy/delta-rs/compare/file_format_options_squashed...adamreeve:delta-rs:test-datafusion-change
   
   ## Are there any user-facing changes?
   
   Yes, this is a breaking API change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to