adamreeve commented on code in PR #21603:
URL: https://github.com/apache/datafusion/pull/21603#discussion_r3078527831
##########
datafusion/common/src/config.rs:
##########
@@ -3024,8 +3024,18 @@ impl From<ConfigFileDecryptionProperties> for
FileDecryptionProperties {
}
#[cfg(feature = "parquet_encryption")]
-impl From<&Arc<FileDecryptionProperties>> for ConfigFileDecryptionProperties {
- fn from(f: &Arc<FileDecryptionProperties>) -> Self {
+impl TryFrom<&Arc<FileDecryptionProperties>> for
ConfigFileDecryptionProperties {
+ type Error = DataFusionError;
+
+ fn try_from(f: &Arc<FileDecryptionProperties>) -> Result<Self> {
+ let footer_key = f.footer_key(None).map_err(|e| {
Review Comment:
Yes, that's not currently possible with the public API of
`FileDecryptionProperties` but I can follow up and change that too. I think it
would still make sense to make this current change and then improve this later
once arrow-rs allows it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
