kumarUjjawal commented on code in PR #21603: URL: https://github.com/apache/datafusion/pull/21603#discussion_r3084400544
########## docs/source/library-user-guide/upgrading/54.0.0.md: ########## @@ -450,3 +450,22 @@ clusters (e.g., ZWJ emoji sequences). For ASCII and most common Unicode text, behavior is unchanged. [#17861]: https://github.com/apache/datafusion/pull/17861 + +### Conversion from `FileDecryptionProperties` to `ConfigFileDecryptionProperties` is now fallible + +Previously, `datafusion_common::config::ConfigFileDecryptionProperties` Review Comment: I think `FileDecryptionProperties::into` is not the old call shape here. Please say `(&decrypt).into()` becomes `(&decrypt).try_into()`, or `ConfigFileDecryptionProperties::from(...)` becomes `try_from(...)`, so the upgrade note matches actual usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
