neilconway commented on code in PR #21538:
URL: https://github.com/apache/datafusion/pull/21538#discussion_r3095874926
##########
datafusion/functions/src/strings.rs:
##########
@@ -106,13 +106,14 @@ impl StringArrayBuilder {
}
}
- pub fn append_offset(&mut self) {
+ pub fn append_offset(&mut self) -> Result<()> {
Review Comment:
Is there a reason why `StringViewArrayBuilder` is `pub`, rather than
`pub(crate)`? It is a fairly special-purpose API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
