alamb commented on code in PR #21538:
URL: https://github.com/apache/datafusion/pull/21538#discussion_r3095893617
##########
datafusion/functions/src/strings.rs:
##########
@@ -106,13 +106,14 @@ impl StringArrayBuilder {
}
}
- pub fn append_offset(&mut self) {
+ pub fn append_offset(&mut self) -> Result<()> {
Review Comment:
TLDR is I don't know -- it got added for some very special purpose reason I
can't remember (I think ideally we would use the upstream one in arrow-rs, but
for some reason we needed a special copy. I can't remember why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
