Blizzara commented on code in PR #712: URL: https://github.com/apache/datafusion-comet/pull/712#discussion_r1689648274
########## native/core/src/execution/datafusion/expressions/comet_scalar_funcs.rs: ########## @@ -0,0 +1,186 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: This file is an extract of what used to be `scalar_funcs.rs`. The `create_comet_physical_expr` isn't easily reusable for others so it seems reasonable to keep it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
