andygrove commented on code in PR #712:
URL: https://github.com/apache/datafusion-comet/pull/712#discussion_r1690445607
##########
native/spark-expr/src/spark_hash.rs:
##########
@@ -34,10 +34,10 @@ use datafusion::{
error::{DataFusionError, Result},
};
-use
crate::execution::datafusion::expressions::xxhash64::spark_compatible_xxhash64;
+use crate::xxhash64::spark_compatible_xxhash64;
#[inline]
-pub(crate) fn spark_compatible_murmur3_hash<T: AsRef<[u8]>>(data: T, seed:
u32) -> u32 {
+pub fn spark_compatible_murmur3_hash<T: AsRef<[u8]>>(data: T, seed: u32) ->
u32 {
Review Comment:
For consistency with other spark functions, we should probably rename this
to `spark_murmur3_hash`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
