Blizzara commented on PR #712: URL: https://github.com/apache/datafusion-comet/pull/712#issuecomment-2249024660
> LGTM. I left a couple comments on naming, and it would be nice if all the public functions had rustdocs, but I would be fine with merging this without those changes. Thanks! I did the rename in https://github.com/apache/datafusion-comet/pull/712/commits/6780bb6e65c3d00238d087c9df533ad848b3c04f, and added docs in https://github.com/apache/datafusion-comet/pull/712/commits/ac291692eee2f0fb03243304711b73189e0d6bda and https://github.com/apache/datafusion-comet/pull/712/commits/8bb99ea1d98a0cbe716722c136c210fec8c1aadd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
