Blizzara commented on code in PR #712:
URL: https://github.com/apache/datafusion-comet/pull/712#discussion_r1691461734
##########
native/spark-expr/src/spark_hash.rs:
##########
@@ -34,10 +34,10 @@ use datafusion::{
error::{DataFusionError, Result},
};
-use
crate::execution::datafusion::expressions::xxhash64::spark_compatible_xxhash64;
+use crate::xxhash64::spark_compatible_xxhash64;
#[inline]
-pub(crate) fn spark_compatible_murmur3_hash<T: AsRef<[u8]>>(data: T, seed:
u32) -> u32 {
+pub fn spark_compatible_murmur3_hash<T: AsRef<[u8]>>(data: T, seed: u32) ->
u32 {
Review Comment:
actually I reverted the rename since this is different form
`spark_murmur3_hash` which we also have (that operates on the ColumnarValues,
while this handles a single value).
Preferably this wouldn't be `pub` but it's used in the `core` crate for
non-expression stuff (like shuffles) so I think it has to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
