pepijnve commented on code in PR #21739:
URL: https://github.com/apache/datafusion/pull/21739#discussion_r3167516672
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -2482,6 +2482,7 @@ impl DataFrame {
relation: None,
name: field.name().to_string(),
metadata: None,
+ is_internal: false,
Review Comment:
Do we still need the `is_internal` flag? I may have overlooked it, but it
doesn't seem to actually be used anymore. It is passed on everywhere, but in
the end setting it to true vs false doesn't seem to have an impact on the
explain output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
