pepijnve commented on code in PR #21739:
URL: https://github.com/apache/datafusion/pull/21739#discussion_r3167929238
##########
datafusion/physical-expr/src/aggregate.rs:
##########
@@ -347,8 +375,13 @@ impl AggregateFunctionExpr {
}
/// Simplified name for `tree` explain.
- pub fn human_display(&self) -> &str {
- &self.human_display
+ pub fn human_display(&self) -> Option<&str> {
+ self.human_display.as_deref()
+ }
+
+ #[doc(hidden)]
+ pub fn has_aliased_human_display(&self) -> bool {
+ self.human_display_is_aliased
Review Comment:
Could this be a derived property of `human_display` or is it necessary for
reliability to make it explicit? Just wondering if it's worth memoizing this
eagerly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
