pepijnve commented on code in PR #21739: URL: https://github.com/apache/datafusion/pull/21739#discussion_r3167530447
########## datafusion/sqllogictest/test_files/aggregates_simplify.slt: ########## @@ -170,9 +170,9 @@ physical_plan 02)--AggregateExec: mode=Final, gby=[], aggr=[sum(alias1), sum(alias2)] 03)----CoalescePartitionsExec 04)------AggregateExec: mode=Partial, gby=[], aggr=[sum(alias1), sum(alias2)] -05)--------AggregateExec: mode=FinalPartitioned, gby=[alias1@0 as alias1], aggr=[alias2] +05)--------AggregateExec: mode=FinalPartitioned, gby=[alias1@0 as alias1], aggr=[sum(__common_expr_1) as alias2] Review Comment: Perfect! This is an example of exactly the kind of issue I was struggling with in the explain plan output. The left hand side here which only contains `aggr=[alias2]` makes the plan unusable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
