goldmedal commented on issue #11639: URL: https://github.com/apache/datafusion/issues/11639#issuecomment-2250895868
Hi @alamb, do you know the purpose of this comment? https://github.com/apache/datafusion/blob/7db4213b71ed9e914c5a4f16954abfa20b091ae3/datafusion/expr/src/logical_plan/builder.rs#L1443-L1458 I believe this expansion for `wildcard` duplicates what the planner does. https://github.com/apache/datafusion/blob/cf9da768306a1e103bfeae68f4f2ed3dfe87df7b/datafusion/sql/src/select.rs#L594-L595 I found the wildcard expression is still expanded even when I disable this behavior in the planner. I think the reason is that the planner invokes the `LogicalPlanner` to build the projection, which will expand the wildcard expression. https://github.com/apache/datafusion/blob/7db4213b71ed9e914c5a4f16954abfa20b091ae3/datafusion/sql/src/select.rs#L693 Could we remove the expansion behavior in the builder? (I guess that's what the comment purposes.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
