jayzhan211 commented on issue #11639: URL: https://github.com/apache/datafusion/issues/11639#issuecomment-2253821179
Correct On Sat, Jul 27, 2024, 2:16 PM Jax Liu ***@***.***> wrote: > @goldmedal <https://github.com/goldmedal> If we move the expression > expansion to analyzer as the comment said, I guess you can still tell the > difference from SELECT * FROM A and SELECT c1, c2, c3 FROM A *before > optimizer*. I think expand expression in builder is quite early, if there > are 1000 columns, we need to carry those columns around in many places. It > is better to delay expansion *lazily* as long as possible. > > I think I got it. So, ideally, we don't do any expansions in the planner > or builder. We need to have an analyze rule or optimize rule to expand the > expression. If we move this to analyze or optimizer, I can get the wildcard > expression before optimizing, even if we don't add a customized behavior in > ExprPlanner, right? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/datafusion/issues/11639#issuecomment-2253813569>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADZCLR3QAJ4XRXA7VKFYJITZOM3KBAVCNFSM6AAAAABLM6DYKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJTHAYTGNJWHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
