andygrove commented on code in PR #4256:
URL: https://github.com/apache/datafusion-comet/pull/4256#discussion_r3209139422
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -360,6 +360,8 @@ object QueryPlanSerde extends Logging with CometExprShim
with CometTypeShim {
_: DoubleType | _: StringType | _: BinaryType | _: TimestampType | _:
TimestampNTZType |
_: DecimalType | _: DateType | _: BooleanType | _: NullType =>
true
+ case dt if dt.getClass.getSimpleName.startsWith("TimeType") =>
Review Comment:
The reflection check `dt.getClass.getSimpleName.startsWith("TimeType")` is
repeated in several spots. Could this be moved behind an `isTimeType(dt)`
helper in `CometTypeShim` (alongside `isVariantStruct`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
