andygrove commented on code in PR #4256: URL: https://github.com/apache/datafusion-comet/pull/4256#discussion_r3209146536
########## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ########## Review Comment: Updating `supportedDataType` to support `TimeType` could impact other expressions (existing and new). Should we be claiming global support? Maybe better to allow this type just for the expressions in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
