Kimahriman commented on code in PR #731: URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1693981199
########## native/core/src/execution/datafusion/expressions/structs.rs: ########## @@ -125,3 +125,103 @@ impl PartialEq<dyn Any> for CreateNamedStruct { .unwrap_or(false) } } + +#[derive(Debug, Hash)] +pub struct GetStructField { Review Comment: Yeah I thought about that, but seemed to make sense to co-locate with CreateNamedStruct. Is it ok to move both in this PR, or do you want me to just move this new one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org