Kimahriman commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1694393741
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -1128,7 +1133,7 @@ object CometSparkSessionExtensions extends Logging {
// Only consider converting leaf nodes to columnar currently, so that all
the following
// operators can have a chance to be converted to columnar.
// TODO: consider converting other intermediate operators to columnar.
- op.isInstanceOf[LeafExecNode] && !op.supportsColumnar &&
isSchemaSupported(op.schema) &&
Review Comment:
Added a little bit more, but still is just a little weird since it's
technically still called `RowToColumnar`
##########
native/core/src/execution/datafusion/expressions/structs.rs:
##########
@@ -125,3 +125,103 @@ impl PartialEq<dyn Any> for CreateNamedStruct {
.unwrap_or(false)
}
}
+
+#[derive(Debug, Hash)]
+pub struct GetStructField {
Review Comment:
Migrated both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
