github-actions[bot] commented on PR #20626: URL: https://github.com/apache/datafusion/pull/20626#issuecomment-4477803695
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 101.454s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.038s] (current) Building datafusion v53.1.0 (baseline) Built [ 96.137s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.985s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CsvReadOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/core/src/datasource/file_format/options.rs:89 field CsvReadOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/core/src/datasource/file_format/options.rs:89 field CsvReadOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/core/src/datasource/file_format/options.rs:89 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 201.677s] datafusion Building datafusion-common v53.1.0 (current) Built [ 31.585s] (current) Parsing datafusion-common v53.1.0 (current) Parsed [ 0.059s] (current) Building datafusion-common v53.1.0 (baseline) Built [ 31.638s] (baseline) Parsing datafusion-common v53.1.0 (baseline) Parsed [ 0.063s] (baseline) Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.948s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CsvOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:3163 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 65.672s] datafusion-common Building datafusion-datasource v53.1.0 (current) Built [ 34.621s] (current) Parsing datafusion-datasource v53.1.0 (current) Parsed [ 0.032s] (current) Building datafusion-datasource v53.1.0 (baseline) Built [ 34.662s] (baseline) Parsing datafusion-datasource v53.1.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion-datasource v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.360s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_now_returns_unit: pub trait method now returns unit --- Description: A trait method that used to return a value now returns `()`. impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_method_now_returns_unit.ron Failed in: datafusion_datasource::decoder::BatchDeserializer::digest in /home/runner/work/datafusion/datafusion/datafusion/datasource/src/decoder.rs:42 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 71.038s] datafusion-datasource Building datafusion-datasource-csv v53.1.0 (current) Built [ 34.942s] (current) Parsing datafusion-datasource-csv v53.1.0 (current) Parsed [ 0.013s] (current) Building datafusion-datasource-csv v53.1.0 (baseline) Built [ 34.928s] (baseline) Parsing datafusion-datasource-csv v53.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-datasource-csv v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.146s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 71.735s] datafusion-datasource-csv Building datafusion-proto v53.1.0 (current) Built [ 51.931s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.141s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 51.892s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.144s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 2.337s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CsvOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/datafusion_proto_common.rs:703 field CsvOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/datafusion_proto_common.rs:703 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 109.012s] datafusion-proto Building datafusion-proto-common v53.1.0 (current) Built [ 20.047s] (current) Parsing datafusion-proto-common v53.1.0 (current) Parsed [ 0.045s] (current) Building datafusion-proto-common v53.1.0 (baseline) Built [ 20.161s] (baseline) Parsing datafusion-proto-common v53.1.0 (baseline) Parsed [ 0.049s] (baseline) Checking datafusion-proto-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.516s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CsvOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:703 field CsvOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:703 field CsvOptions.charset in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:703 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 43.012s] datafusion-proto-common ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
