alamb commented on code in PR #20626:
URL: https://github.com/apache/datafusion/pull/20626#discussion_r3261760139
##########
Cargo.toml:
##########
@@ -159,12 +159,13 @@ datafusion-sql = { path = "datafusion/sql", version =
"53.1.0" }
datafusion-substrait = { path = "datafusion/substrait", version = "53.1.0" }
doc-comment = "0.3"
+encoding_rs = "0.8"
Review Comment:
I think we are trying to keep our (already large) dependency chain from
growing
https://crates.io/crates/encoding_rs seems to be a pretty large dependency
(as it supports many different encodings) to me
##########
README.md:
##########
@@ -133,6 +131,7 @@ Optional features:
- `avro`: support for reading the [Apache Avro] format
- `backtrace`: include backtrace information in error messages
+- `encoding_rs`: support for reading files with character encodings other than
UTF-8
Review Comment:
the feature doesn't look optional to me (it doesn't have `optional=true` in
the `Cargo.toml`) file. Perhaps I am misreading this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
