asolimando commented on PR #22343: URL: https://github.com/apache/datafusion/pull/22343#issuecomment-4480327430
I agree on the general idea, but considering short-circuiting and also conjuncts' selectivity, this can actually backfire in practice, so a config knob seems important to have (I might have missed it, but I couldn't see it in the PR). Ideally `reorder_predicates` should be over ridable, to give downstream systems a chance to change behavior if needed, but also to complement knowledge about UDFs which core DF can't know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
