alamb opened a new pull request, #11734: URL: https://github.com/apache/datafusion/pull/11734
Builds on https://github.com/apache/datafusion/pull/11627 from @korowa TODO: write tests ## Which issue does this PR close? N/A ## Rationale for this change To take advantage of the benefits of https://github.com/apache/datafusion/pull/11627 a new method must be implemented for each accumulator. At least one ClickBench query (the one in https://github.com/apache/datafusion/issues/6937) uses Avg ## What changes are included in this PR? 1. Implement `convert_to_state` for `AVG` accumulator ## Are these changes tested? Not yet <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
