alamb commented on PR #11734: URL: https://github.com/apache/datafusion/pull/11734#issuecomment-2275579264
> LGTM, thank you @alamb. > > Regarding q28 slowdown from PR description -- I suppose it's not a stable slowdown, and just a result on single benchmark run (since the regexp over `Referrer` field in the query doesn't seem to produce high enough cardinality to skip partial aggregation)? That is my understanding too. I also have high hopes that the StringView work will make that query in particualr faster as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
