jayshrivastava commented on code in PR #22464:
URL: https://github.com/apache/datafusion/pull/22464#discussion_r3292023198
##########
datafusion/physical-expr/src/expressions/unknown_column.rs:
##########
@@ -84,6 +87,36 @@ impl PhysicalExpr for UnKnownColumn {
fn fmt_sql(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
std::fmt::Display::fmt(self, f)
}
+
+ #[cfg(feature = "proto")]
+ fn try_to_proto(
+ &self,
+ _ctx:
&datafusion_physical_expr_common::physical_expr::proto_encode::PhysicalExprEncodeCtx<'_>,
+ ) -> Result<Option<protobuf::PhysicalExprNode>> {
+ Ok(Some(protobuf::PhysicalExprNode {
+ expr_id: None,
+ expr_type:
Some(protobuf::physical_expr_node::ExprType::UnknownColumn(
+ protobuf::UnknownColumn {
+ name: self.name.clone(),
+ },
+ )),
+ }))
Review Comment:
> while the previous inlined serialization path in to_proto.rs populated
expr_id from the serializer’s expr_id
I believe this variable was an option and was `None` since only dynamic
filters set expr_id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
