koopatroopa787 commented on code in PR #22464:
URL: https://github.com/apache/datafusion/pull/22464#discussion_r3298363499
##########
datafusion/physical-expr/src/expressions/unknown_column.rs:
##########
@@ -99,3 +139,83 @@ impl PartialEq for UnKnownColumn {
false
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ #[cfg(feature = "proto")]
+ use std::sync::Arc;
+
+ #[cfg(feature = "proto")]
+ use arrow::datatypes::Schema;
+
+ #[cfg(feature = "proto")]
+ use datafusion_common::{Result, internal_err};
Review Comment:
these explicit imports are still needed. use super::* only brings in items
defined in the parent module (like UnKnownColumn itself) — it does NOT
re-export items that are only privately used in the parent scope (like Arc,
Schema, Result, internal_err). You can see the same pattern in binary.rs's test
module, which also uses use super::* but still explicitly imports use
arrow::array::BooleanArray and others. Removing these would cause compile
errors when the proto feature is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
