kumarUjjawal commented on code in PR #22464:
URL: https://github.com/apache/datafusion/pull/22464#discussion_r3296149584
##########
datafusion/physical-expr/src/expressions/unknown_column.rs:
##########
@@ -99,3 +139,83 @@ impl PartialEq for UnKnownColumn {
false
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ #[cfg(feature = "proto")]
+ use std::sync::Arc;
+
+ #[cfg(feature = "proto")]
+ use arrow::datatypes::Schema;
+
+ #[cfg(feature = "proto")]
+ use datafusion_common::{Result, internal_err};
Review Comment:
do we need these re-imports since we are already using super?
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -4889,10 +4889,22 @@ mod tests {
);
// The probability of being distinct is 1 - 1 / 16 = 15 / 16.
- assert_eq!(
- neq.evaluate_statistics(&[left_stat, right_stat])?,
- Distribution::new_bernoulli(ScalarValue::from(15.0 / 16.0))?
- );
+ let got = neq.evaluate_statistics(&[left_stat, right_stat])?;
+ let expected = Distribution::new_bernoulli(ScalarValue::from(15.0 /
16.0))?;
Review Comment:
What is this test change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
