parthchandra commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1699276896
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -1115,6 +1119,7 @@ object CometSparkSessionExtensions extends Logging {
BinaryType | StringType | _: DecimalType | DateType | TimestampType =>
true
case t: DataType if t.typeName == "timestamp_ntz" => true
+ case s: StructType => isSchemaSupported(s)
Review Comment:
Hmm. I'm concerned that someone might use this method and get unexpected
behavior. A comment to explain why this is here would be justified, I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
