kazuyukitanimura commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1698995172
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometBatchScanExec.scala:
##########
@@ -152,3 +153,17 @@ case class CometBatchScanExec(wrapped: BatchScanExec,
runtimeFilters: Seq[Expres
override def supportsColumnar: Boolean = true
}
+
+object CometBatchScanExec {
+
+ def isSchemaSupported(schema: StructType): Boolean =
Review Comment:
I see. Is it possible to create a base trait? So that we can share the logic
for be basic types between different objects.
Then perhaps new `CometRowToColumnarExec` object can inherit it and call
super + extra type match.
I cannot think cases like a type supported only in `CometBatchScanExec` but
not in `CometScanExec`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
