kazuyukitanimura commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1698961203
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometBatchScanExec.scala:
##########
@@ -152,3 +153,17 @@ case class CometBatchScanExec(wrapped: BatchScanExec,
runtimeFilters: Seq[Expres
override def supportsColumnar: Boolean = true
}
+
+object CometBatchScanExec {
+
+ def isSchemaSupported(schema: StructType): Boolean =
Review Comment:
Got it. Let's delete the original one then? With this PR it is no longer
used I think.
Also this object should be package private unless we add a test for it.
`isTypeSupported` should be `private` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
