gene-bordegaray commented on code in PR #22590:
URL: https://github.com/apache/datafusion/pull/22590#discussion_r3320460002
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -411,6 +459,37 @@ fn compare_scalar_values_for_sort(
}
}
+fn equivalent_exprs(
Review Comment:
Agreed that this pattern is more general. I kept this helper private for now
to avoid introducing a big abstraction before we have more call sites and then
we can shape around that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
