gene-bordegaray commented on code in PR #22590:
URL: https://github.com/apache/datafusion/pull/22590#discussion_r3320476919
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -442,6 +521,42 @@ impl Partitioning {
}
}
+ /// Returns true when `self` and `other` describe compatible partition
maps.
+ ///
+ /// Compatible partition maps can be used for partition-local behavior: if
+ /// this returns true, partition `i` from both partitionings can be treated
+ /// as covering the same partition domain. This is stricter than
+ /// [`Self::satisfaction`], which only answers whether this partitioning
can
+ /// satisfy a required distribution.
Review Comment:
They are related and quite similar I will say, but `allow_subset=false` is
not equivalent because satisfaction checks a partitioning against a
distribution. Compatibility checks whether two partitioning maps align
partition-by-partition. Compatibility needs things that `Distribution` does not
carr like partition count and range split points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
