gene-bordegaray commented on code in PR #22590:
URL: https://github.com/apache/datafusion/pull/22590#discussion_r3324738763
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -442,6 +521,42 @@ impl Partitioning {
}
}
+ /// Returns true when `self` and `other` describe compatible partition
maps.
+ ///
+ /// Compatible partition maps can be used for partition-local behavior: if
+ /// this returns true, partition `i` from both partitionings can be treated
+ /// as covering the same partition domain. This is stricter than
+ /// [`Self::satisfaction`], which only answers whether this partitioning
can
+ /// satisfy a required distribution.
+ pub fn compatible_with(
Review Comment:
here is code in a draft PR with the SLT PR also cherry picked onto it to see
how it will be used:
https://github.com/gene-bordegaray/datafusion/pull/4/changes#diff-655b0a4f475d2886b064413051318666e5c52a39950fb997d84a1863bd764af6R204
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -442,6 +521,42 @@ impl Partitioning {
}
}
+ /// Returns true when `self` and `other` describe compatible partition
maps.
+ ///
+ /// Compatible partition maps can be used for partition-local behavior: if
+ /// this returns true, partition `i` from both partitionings can be treated
+ /// as covering the same partition domain. This is stricter than
+ /// [`Self::satisfaction`], which only answers whether this partitioning
can
+ /// satisfy a required distribution.
+ pub fn compatible_with(
Review Comment:
note this is not fully complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
