gittihub-jpg opened a new pull request, #4559: URL: https://github.com/apache/datafusion-comet/pull/4559
Closes #4491. ## Rationale for this change CometCast.isSupported lacks a MapType arm, so any cast involving map types hits the default case and falls back to Spark. The native implementation already supports map-to-map conversion via cast_map_to_map in cast.rs. Routing Scala casts to this function removes unnecessary fallbacks and improves execution performance. ## What changes are included in this PR? Add a case for (MapType, MapType) in CometCast.isSupported. The new logic recursively checks key types and value types using isSupported. It returns Compatible when both recursive checks pass, or Incompatible with a descriptive reason string otherwise. No Rust changes are required since the native cast_map_to_map function already exists. ## How are these changes tested? Existing unit tests for CometCast cover type compatibility checks. The new MapType branch is validated by running the full test suite and verifying that map-to-map casts no longer trigger a fallback to Spark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
