gittihub-jpg commented on PR #4559:
URL:
https://github.com/apache/datafusion-comet/pull/4559#issuecomment-4616645455
Hi, thanks for feedback, somehow deleted the old tests?
added new test in CometCastSuite ("cast MapType to MapType").
To make sure the cast actually runs in Comet and isn't just done by Spark:
it writes a map<int,int> to Parquet, reads it back with
USE_V1_SOURCE_LIST=parquet so the map is read natively, then casts to
map<long,string> and checks with checkSparkAnswerAndOperator that the result
matches Spark and no fallback happens. Without this change the cast falls back,
so the test would fail.
Happy to add more key/value type combos if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]