github-actions[bot] commented on PR #22584: URL: https://github.com/apache/datafusion/pull/22584#issuecomment-4597346004
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-ffi v53.1.0 (current) Built [ 59.598s] (current) Parsing datafusion-ffi v53.1.0 (current) Parsed [ 0.058s] (current) Building datafusion-ffi v53.1.0 (baseline) Built [ 58.763s] (baseline) Parsing datafusion-ffi v53.1.0 (baseline) Parsed [ 0.057s] (baseline) Checking datafusion-ffi v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.249s] 222 checks: 220 pass, 1 fail, 1 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ForeignLibraryModule.create_context_aware_optimizer_rule in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:116 field FFI_PhysicalOptimizerRule.optimize_with_context in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_optimizer.rs:138 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_PhysicalOptimizerRule.name moved from position 2 to 3, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_optimizer.rs:144 FFI_PhysicalOptimizerRule.schema_check moved from position 3 to 4, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_optimizer.rs:146 FFI_PhysicalOptimizerRule.clone moved from position 4 to 5, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_optimizer.rs:150 FFI_PhysicalOptimizerRule.release moved from position 5 to 6, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_optimizer.rs:153 FFI_PhysicalOptimizerRule.version moved from position 6 to 7, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_optimizer.rs:156 FFI_PhysicalOptimizerRule.private_data moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_optimizer.rs:160 FFI_PhysicalOptimizerRule.library_marker_id moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_optimizer.rs:164 ForeignLibraryModule.version moved from position 17 to 18, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:118 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 120.247s] datafusion-ffi ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
