nathanb9 commented on PR #22584: URL: https://github.com/apache/datafusion/pull/22584#issuecomment-4622844891
- **`has_statistics_registry` unused (line 48):** Agreed — removed it and the backing fn. The context struct now only exposes `config_options` + lifecycle (`release`). If we later need to query registry capabilities across FFI we can add a targeted callback then. - **Unnecessary registry clone (line 71):** Good call. Removed the clone entirely — `OptimizerContextPrivateData` no longer stores the registry at all. - **Field ordering (line 143):** Moved `optimize_with_context` after `version` and before the data fields, so existing slot offsets stay stable. - **`ForeignLibraryModule` adds required field (mod.rs line 116):** Acknowledged — the `api change` label covers it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
