ariel-miculas commented on code in PR #22712: URL: https://github.com/apache/datafusion/pull/22712#discussion_r3343122581
########## datafusion/physical-plan/src/aggregates/group_values/single_group_by/blocked_primitive.rs: ########## @@ -0,0 +1,318 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::aggregates::group_values::GroupValues; +use crate::aggregates::group_values::single_group_by::primitive::HashValue; + +use arrow::array::{ + ArrayRef, ArrowNativeTypeOp, ArrowPrimitiveType, NullBufferBuilder, PrimitiveArray, + cast::AsArray, +}; +use arrow::datatypes::DataType; +use datafusion_common::Result; +use datafusion_common::hash_utils::RandomState; +use datafusion_execution::memory_pool::proxy::VecAllocExt; +use datafusion_expr::EmitTo; +use hashbrown::hash_table::HashTable; +use std::mem::size_of; +use std::sync::Arc; + +/// A single-column primitive [`GroupValues`] that stores group keys in fixed +/// sized blocks. Group ids are still logically contiguous: +/// +/// ```text +/// group_id = block_index * block_size + offset_in_block +/// ``` +/// +/// `EmitTo::Block` consumes exactly one stored block, so callers that configure +/// accumulators with the same block size can build output batches without first +/// materializing one large contiguous values vector. +pub struct GroupValuesPrimitiveBlock<T: ArrowPrimitiveType> { + data_type: DataType, + map: HashTable<(usize, u64)>, + null_group: Option<usize>, + blocks: Vec<Box<[T::Native]>>, Review Comment: Because of the performance overhead of removing the first elements from a Vec, I would consider other approaches, maybe VecDeque -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
