ariel-miculas commented on code in PR #22712:
URL: https://github.com/apache/datafusion/pull/22712#discussion_r3347268054
##########
datafusion/expr-common/src/groups_accumulator.rs:
##########
@@ -25,6 +25,15 @@ use datafusion_common::{Result, not_impl_err};
pub enum EmitTo {
/// Emit all groups
All,
+ /// Emit one implementation-defined block of groups.
+ ///
+ /// This is intended for accumulators and group-value stores whose internal
+ /// representation is already split into fixed-size blocks. Implementations
+ /// that do not advertise blocked emit support may return an internal
error.
+ ///
+ /// Callers should only use this once no further updates will arrive for
the
+ /// current groups.
Review Comment:
When the partial hash aggregation hits the OOM condition, it triggers an
early emit, draining all the existing groups and then continuing with
processing input batches.
Is this use case supported with the EmitTo::Block approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
